I was going to post this as a separate question until I came across this topic. If something seems off about the wording it's because it was meant as a standalone post.
I believe my point of view differs from most of the already provided answers in that it focuses more on raising awareness rather than reprisal on the offenders.
The issue I'm having with the suggested edit review queue is very simple: people are encouraging insufficient edits by approving them anyway.
I have seen a lot of edits passing by that either only partially fix something or plain deface the post that end up getting approved. The following are a few samples of edits in the last hour (2 different users), but this certainly wasn't a temporal surge of low quality edits.
Situation 1
https://stackoverflow.com/review/suggested-edits/3667680
At first glance this doesn't seem too bad. Then when you look more closely:
- Language tag in title
- Incomplete code formatting (
Student
and Course
remain unticked)
- None of the English has been fixed
When you look at the total revisions for this answer you can see it needed 3 more revisions to get in a decent shape.
Situation 2
https://stackoverflow.com/review/suggested-edits/3667621
- Random code formatting
- No English fixed
- "Thanks" not removed
Once again a case of just clicking the {}
button a few times and leaving everything else in there
Situation 3
https://stackoverflow.com/review/suggested-edits/3667617
- Language tag in title
- Random code formatting
- Error message in code format, making it hard to read
The only substantial edit isn't a particularly useful one.
Situation 4
https://stackoverflow.com/review/suggested-edits/3667520
This one actually got rejected but it still got 2 approval votes.
It literally has nothing going for it:
- Horrible title unfixed
- Random code formatting
- Added incorrect English
- Removed 2 lines of whitespace, left 3 others in there and didn't touch indentation
Still he got 2 approval votes.
Situations 5, 6 & 7
https://stackoverflow.com/review/suggested-edits/3667714
https://stackoverflow.com/review/suggested-edits/3667686
https://stackoverflow.com/review/suggested-edits/3667650
Each of these edits got approved while the only thing they do is put jsfiddle links behind a word and bolden a few words that were already distinguished by separation.
In fact there are still several (minor) issues that aren't touched at all. If these things were valid enough to let trough then the other stuff should be valid enough to reject the edit as well:
- Code formatted with bold instead of code formatting
- Irrelevant tag
- Code not indented
What am I trying to reach with this post?
I believe there are a few issues here.
- I waste time by both correcting the original post and the suggested edit.
- If it gets approved before I get my hands on it, people will read a post that has poor quality.
- A question gets pushed to the top despite nothing substantially being changed.
- Insufficient edits are indirectly encouraged because seemingly many of them are being approved.
- The trustworthy representation of a user is inflated because he gains reputation without adding value to the network.
I believe the main offenders here are the people who approve these suggestions and subsequently encourage this behaviour. We as reviewers have the possibility to stop these edits from entering the system but seemingly we're failing as a group at this task a substantial amount of time.
I won't deny that I might have set the bar higher than is commonly accepted, but I strongly doubt that these suggestions should've been allowed. Edits should ideally address all issues in a post whereas the samples I posted definitely don't do that. Either they plain deface the post and perform one specific and often incorrect action (person 1) or they invent problems and make unimportant changes.
What can we do?
I think it's important to provide feedback to people about how they voted. As far as I'm aware we don't have any possibility to see how the rest of the reviewers voted on an edit unless you explicitly keep track of the edit. This is a lot of work that will require a lot of tabs to keep open and shouldn't have to be done in the first place.
Those that suggested an invalid edit should receive a notification when their suggestion got declined. I haven't done any suggested edits in my pre-2k period so I don't if this is possible (let me know if it is), but if the "custom message" option actually gets shown to the person himself, we can use that as a way of communicating about what he should change in the future.
This would be mainly aimed at the people who go on invalid suggestion spree, usually you get a few of them if you're on a review spree.
Then again, messages might not be enough. As it is now there is a formula in place that blocks people from suggesting edits for a 7 day period if they get too many rejects.
The formula is
(rejects - (approvals / 3)) >= 5
This is in itself a good formula but I believe we can do more with it. When it comes to adjusting behaviour, going from no notion to full stop is rarely a good idea. People will get banned for too many rejections and they're basically left with one feeling: why wasn't I told in time?
I think that's exactly what should happen. As soon as you reach certain tresholds you should get a warning that you're getting too many rejections. By working in stages and positively approving people when they become more in-line with the rest of the community it's a lot easier to correct this (we'll bypass any philosophical discussions by assuming the community as a whole has the correct judgement).
By adding these warnings users will more quickly be notified when they're getting rejected a lot and will be able to improve their suggestions sooner. Likewise they will have the feedback of the positive notifications from the system when it tells them their suggestions are getting approved a lot more.
In short:
- Give us a result of our votes. Either instantly or at the end of the day let us know how the cases we ruled on were decided by the community.
- Let users know when their suggestions were rejected and why.
- Provide warnings when a user is getting close to the lockout period.
- Provide a positive notification when a user's aproval rating is rising.