What is meta? ×
Meta Stack Exchange is where users like you discuss bugs, features, and support issues that affect the software powering all 133 Stack Exchange communities.

There's something wrong with the inline diff in Revision 3 here (compare with source diff)

Don't really know how to explain it, so I'll let the revisions speak for themselves. The inline diff seems to have given up outputting anything at the <br/>.

As an aside, formatting the headers and bullet lists underneath that numbered list was a right pain in the neck.

share|improve this question

1 Answer 1

up vote 6 down vote accepted

Yes, it was indeed the <br/> (to be precise, it was the self-closing / at the end) that wasn't handled correctly and thus broke here (in particular due to the condensing of long diffs). I've made two changes:

  1. This particular case is now handled correctly, and
  2. in case similar issues happen in the future, this will a) be logged in our error log, and b) the condensing bails out and shows the uncondensed version instead, so nothing is hidden from the diff view, even if there's a bug causing the condensing to fail.

This goes live with the next build.

share|improve this answer
    
Nice one! Shall verify and accept. How often do builds get pushed out? –  Lightness Races in Orbit Oct 3 '11 at 19:22
    
Ususally between one and maybe five times per day. Also see meta.stackexchange.com/questions/106523/… –  balpha Oct 3 '11 at 19:51
    
Nice one; and I can verify the fix. Top qual. –  Lightness Races in Orbit Oct 4 '11 at 8:23

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .