What is meta? ×
Meta Stack Exchange is where users like you discuss bugs, features, and support issues that affect the software powering all 131 Stack Exchange communities.

After clicking "Improve" on a suggested edit and making additional modifications, the suggested edit gets approved by the Community user instead of the user who Improved the post.

Do these edits count toward the proofreader and reviewer badges?

From my observations, it seems like they do not.

share|improve this question
    
Well, it does presumably count toward copy editor, so I'm not sure it needs to count toward even more badges. –  hammar Feb 15 '12 at 13:53

3 Answers 3

up vote 6 down vote accepted

Until now, "Improve" did not count toward the count of actions that trigger the Proofreader badge.

But given we've now replaced "Improve" with actions that explicitly reject or approve edits, it seems fair to make these edits count toward the badge as well - after all, they are approve/reject reviews, they just happen to include an edit as well!

Geoff has made the change - after the next build, a few enthusiastic editors will be getting a new badge.

share|improve this answer
    
worth noting that approvals and rejections through "Improve" are currently attributed to Community user, and reviewer stats for approvals / rejections aren't displayed –  gnat Sep 22 at 9:28
    
Ah, I was wondering why I got that badge today. My last rejection or approval of a proposed edit was two weeks ago. –  Ross Ridge Sep 22 at 19:38

I ran a little experiment:

  1. Opened up one of my recently actioned suggested edits and observed my approve/reject count:

    Rob Hruska approved 222 edit suggestions, and rejected 96 edit suggestions.

  2. Made the second "Approve" action on another suggested edit, resulting in its Approval:

  3. Observed an immediately updated approve/reject count on the approved edit:

    Rob Hruska approved 223 edit suggestions, and rejected 96 edit suggestions.

    This was to see if the edit counts were cached or delayed.

  4. Improved a suggested edit that had already received one "Approve" vote (also marked the edit as "helpful" when approving, but I doubt that matters).

  5. Observed that the edit was approved by the first approver and Community.
  6. Went back to one of my previous actioned edits and observed my approve/reject counts:

    Rob Hruska approved 223 edit suggestions, and rejected 96 edit suggestions.

If the badge progress is solely calculated from the approve/reject counts I observed (which is just an assumption), it would appear that Improving a suggested edit does not increase the counts, and would therefore not count toward the badge.


If the above is true (that counts aren't increased), it seems that this would discourage the behavior that the Improve button encourages: users might be inclined to simply Approve an edit instead of Improve it (to receive the Reviewer badge progress). This would likely only be an issue if they already had the Copy Editor badge (since if they didn't, either action would count toward a badge).

share|improve this answer
    
Those numbers don't have to be the same numbers the code looks at for the badge, though. Overall, this business is a bit weird. For example, that snippet adds up to 223+96=319 decisions, but your reviews tab says 306. –  lunboks Feb 15 '12 at 14:21
    
@lunboks - That's correct, they may not be. I'm making that assumption with my post, but would love to be corrected by a dev if the assumption's not correct. –  Rob Hruska Feb 15 '12 at 14:22
    
@lunboks - Also, interesting observation about the count differences. Hadn't noticed that. I'm gonna have to post another question about that. –  Rob Hruska Feb 15 '12 at 14:26
    

When you improve a suggested edit, it gets approved by Community; you result as user that edited the post. As consequence of this, that post doesn't result between your reviews, and it doesn't count to get the badge.

For example, I improved a suggested edit for an answer on OCJP - to implement printf in java (February 9); the revision page for that answer shows the following:

screenshot

The "reviews" tab doesn't show it as one my reviews, but it is shown for the Community user.

screenshot

If you then click on the "suggested" link shown in the revisions page for that answer, you will notice that Community user is reported to be the approver, not me.

screenshot

Improved edits are not counted as reviews; that is what I have experienced in the Stack Exchange sites where I am active.

share|improve this answer
    
This matches my observations. Now, for the "Should they?" part... :P –  Rob Hruska Feb 15 '12 at 16:30
    
Perhaps I should move that into a separate question. –  Rob Hruska Feb 15 '12 at 16:30
    
I think they should, especially on Stack Overflow where two users needs to approve or reject a suggested edit. If improving a suggested edit would be counted, it would be like a work-around to the "two users needs to approve an edit" rule. –  kiamlaluno Feb 15 '12 at 20:11
    
Yeah, the whole two-vote system feels weird to me in general. –  Rob Hruska Feb 15 '12 at 20:24
    
I meant, they should not count as approved edits. –  kiamlaluno Feb 15 '12 at 20:29
    
Update: Improving edits now counts as a review. –  animuson Feb 1 '13 at 6:30

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .