What is meta? ×
Meta Stack Exchange is where users like you discuss bugs, features, and support issues that affect the software powering all 127 Stack Exchange communities.

I am fairly new to SO and still have a lot of things to learn about its system. Regarding my question, there have been numerous questions like this and still after going through them I am finding myself confused. With the danger of being marked duplicate question I feel compelled to ask it here.

In past few days I have tried adding to (as opposed to pure 'editing') two answers to two different questions (both questions are still 'unanswered' in the sense that none has an accepted answer). I thought the answers I edited were largely correct but missed out on some crucial detail.

My edits:

  1. http://stackoverflow.com/suggested-edits/302562 : My edit here seamlessly integrates with the original post.
  2. http://stackoverflow.com/suggested-edits/304682: Here I mentioned 'edited by' and added my answer.

Both the edits have been rejected.

Note: After going through the answers to some of the similar questions I gather that mentioning 'edited by' yourself is not considered good. This point has been well taken note of now.

My questions are:

  1. I as a new user of SO found the reason of rejection of edits insufficient. It left me clueless as to the steps I need to take to improve my editing conduct on the site. Would having a small 'description/comment' from the reviewer about the problem with the edit help?
  2. As I said I am a bit clueless as to how to improve these specific edits (or if it was altogether wrong to add to the answers instead of 'editing' them). May anybody more experienced on SO help here?
  3. One of the questions out of two was marked closed as ambiguous question. But still, for whatever could be understood from the question there was an answer posted for it. I felt this answer could be improved by adding some more detail. Should the 'closed' questions be left as it is and one should not try to improve the questions/answers?
  4. And lastly IMHO a more detailed FAQ/Guidelines page regarding editing can help new users like me a lot on SO. http://stackoverflow.com/faq does not really answer this stuff.
share|improve this question
    
The thing is: when you edit the content of the post and make a suggested edit, only 2 or 3 people (in the best case) will go and check whether the content is correct or not. If you post your answer, you will earn rep + it is checked by many other users. –  nhahtdh Jul 5 '12 at 6:52
    
@nhahtdh Yes I understand new answer can gain reputation and edits can't. But I thought, since the hard part has already been done by some other person I can just add my 5 cents to it :) –  Amit Mittal Jul 5 '12 at 6:55
1  
Sorry, my comment is a bit misleading. The point is checking whether your contribution is correct or not. Rep may not may not matter. –  nhahtdh Jul 5 '12 at 6:59
add comment

2 Answers

up vote 3 down vote accepted

With so many points, you really should have posted this as separate questions (maybe not four questions, but having radically different questions stuffed in one post is a bad idea)


Point 1:

See Pending approvals: allow for adding reasons to rejections

It is possible, but the reviewer doesn't have to. Your edit fitted a run-of-the-mill rejection reason, there was no need for anything special for it.

Point 2:

In both cases, you are adding a sizeable chunk of content to the post. Normally, you may not want to do that--a few fixes (small clarifications here and there, formatting, linking, grammar) are good- but adding a whole chunk of content is frowned upon.

Instead, you comment on the post and ask the user to incorporate a bit about XYZ into it--this is what comments are for.

I, personally, rarely make such edits to posts (even with editing privileges), unless I've interacted with the person well enough to know that s/he won't mind (and I let them know via a comment--though now, due to the new notification system, this isn't strictly necessary)


Edited by @AmitMittal:

@C.Evenhuis is largely correct

Unmanaged dlls can not be loaded through Assembly Resolve event (it will not be fired for unmanaged dlls). For this at start-up (or at-least before the point where you are sure that the application will not have tried to load the unmanaged dll) you need to write the unmanaged dll to a disk file.

Location of the dll should either be in the Environment PATH variable or the location from where your application is running.

Best way to look for the locations where OS tries to search the dll is using sysinternal's ProcMon by monitoring the file read/write activity of the application's process.

This obviously belongs as a comment. If your comment is becoming too long, you can use multiple comments or move to chat. Finally, the poster can edit the clarifications in (or you can ask him to approve your edit, one can approve edits to one's own post even without 5k rep)


In fact if all funtions are inlined paging activity can increase dramatically and hence decrease performance as opposed to increase it.

As part of jump to the function instructions, compiler also generates code so that any arguments required by the function can be passed to it (for this read on Calling conventions). Called function will have its own stack frame (placed on top of the calling functions stack frame in the processor's stack) to store its local variables. Once the called function returns this stack frame will be destroyed (i.e. called function's local variables will go out of scope).

This is a whole new bit of content, and not just a clarification. Again, it is better if you suggested the poster to add this (or asked for permission and added it yourself)

Point 3:

Generally, for closed questions, it is better to edit the question so that it is up to scratch and flag for reopening. There is nothing wrong about editing the answer, but fixing the question first is much more useful to the site. Usually, if someone has managed to answer a question that is hard to understand, that means that they have managed to interpret it. Usually, reading the answer helps you understand the question better, and you can fix this.

Unfortunately, the question you linked to probably was closed as "too broad", not "hard to understand"--since "compiler" is a generic term, and different compilers work differently. Again, there is no issue in improving the answer--but not much point doing so.

Point 4

Note that there is a larger faq here.

There are a lot of things that should be in the faq--we don't want it to be overwhelming. I personally think that a better idea would be this:

  • Notify a user of a rejected edit (dunno if that happens already)
  • The boilerplate rejection reasons should link to explanations on meta.

Unfortunately, for this particular issue, not everyone is in agreement on which edits should be rejected. So there is a bit of ambiguity here, and it is better to play it safe with edits of the form I mentioned in point 3 (small clarifications here and there, formatting, linking, grammar)

share|improve this answer
    
Thanks for explanation. Like I said these were 'additions' instead of 'pure edits'. So point that can be taken here is, for additions consider comments and only if you wish to improve small points (like grammar etc.) chose edit. Am I correct? –  Amit Mittal Jul 5 '12 at 6:41
    
@AmitMittal Like I said: Grammar, formatting, links, and small clarifications are usually safe. (Though try to make the sum of these edits substantial--if you just fix one word, it is likely to be rejected) –  Manishearth Jul 5 '12 at 6:43
    
Thanks. It fully answers point 2 of my question and I find myself more wise regarding the expectations from me while editing :). May you please add your thoughts on other points as well? –  Amit Mittal Jul 5 '12 at 6:46
    
@AmitMittal: Done –  Manishearth Jul 5 '12 at 7:01
    
Thanks. Probably a link to meta FAQ on SO can also help. And No, I didn't get a notification of rejection, though I am not sure if there is a preference for that. –  Amit Mittal Jul 5 '12 at 7:08
1  
@AmitMittal: There aren't prefs yet, though I hope that they will be introduced sometime. –  Manishearth Jul 5 '12 at 7:12
add comment

Both of these look to me like they should be comments on the answers rather than edits, and the answerer can edit the content in if they deem it appropriate. Additionally, @ notifications only work in comments, so putting "@username" in an answer is largely useless.

share|improve this answer
    
Point well taken about @username. As to the comments versus edit, would having a feature where the reviewer mentions it as such or a new 'rejection reason' help here? Further meta.stackexchange.com/questions/19477/… encourages to add to the answers to make them complete. At-least stackoverflow.com/suggested-edits/304682 added some detail which the OA was not sure about. Like I said I am confused :) –  Amit Mittal Jul 5 '12 at 6:31
add comment

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .