What is meta? ×
Meta Stack Exchange is where users like you discuss bugs, features, and support issues that affect the software powering all 134 Stack Exchange communities.

Randomly I look if I got a rejected suggestion and I found one from these days. But I really don't get it.
My POV in this case is that I took question-comments from others and their answer-comment from OP. And that I did not include any answer to the question itself.

There are more like this or this. The reject in shown cases came from a user with higher rep and an approve from a lower rep one, so I assume he/ she knows why and what. But I don't understand the (stock) phrase. And in lack of a private chat system I can't ask him/ her directly.

I know that only the rejecters know why the rejected, but I hope other users still can enlight me because I don't like to annoy the review system. So my question is: Where did I edit wrong in particular?

share|improve this question
3  
Tips: try to get the OP to edit the post rather than doing it yourself - it makes the person aware of the feature. And don't add tags if you're not sure they belong. Put "maybe this needs tags [such] [and such]" in the edit comment instead. AFAIK the edit is fine, but you're asking "a lot of work" from the reviewers (check out the question, review the edit wrt posted comments, think about the tags.) –  Mat Sep 4 '12 at 7:35
    
This actually came up in my queue - and I actually passed on it as Not Sure. While it seems fairly legit, it does make a lot of changes to the original question. In my case, unless I am totally certain one way or another, I just ask for the next edit. Perhaps as I get more familiar and confident with editing I will approve these, but I would love to see how many people passed on that one in particular. –  Fluffeh Sep 4 '12 at 7:41
2  
You could probably add "moved OP comments into the question" to make it clearer; these kind of edits sometimes take me by surprise, so having a more explicit edit description helps a lot. –  Jack Sep 4 '12 at 7:41
7  
Do me a favor... do not edit code in questions. Also, the "Edit:" notation should be dropped. –  Time Traveling Bobby Sep 4 '12 at 7:42
    
One option is to earn enough rep that your edits are no longer suggestions and don't require approval. –  slugster Sep 4 '12 at 7:45
    
Okay, I will drop the "Edit:" and yes, code editing is bad, the missing "{": I yielded to temptation. Yes, I ask about a lot of work to see if I included the right comments because it took me same work to get it in. So I will state it more clear in the long conclusion line. –  Shegit Brahm Sep 4 '12 at 7:52
    
I wouldn't have approved the last one btw; where did <!-- language-all: lang-php --> come from? –  Jack Sep 4 '12 at 7:52
    
@Jack This comes from the Question. And usually the highlighting appears from question tags and there are no concurring ones in this case. But in preview this is not all time visible. And only 6 blanks are not valid. –  Shegit Brahm Sep 4 '12 at 7:55
2  
in copying-comments suggestions, I would use a horizontal separator --- instead of "Edit from comments:" and I'd comment like "clarification copied into question from OP comments". Other than that, these look pretty good –  gnat Sep 4 '12 at 7:57
    
@Mat You are right, I have to try it for every case again. I usually refuse to do if the OP was offline since more than a month. –  Shegit Brahm Sep 4 '12 at 7:58
5  
I agree with Bobby - changing code is reason enough to reject an edit. Code of answer might be improved to certain level as long as not radically changing it, but code in the question itself is many times the source of the problem so fixing it pretty much turns the whole question pointless. Indentation is the only thing that should be fixed in those cases. –  Shadow Wizard Sep 4 '12 at 8:21
3  
By the way, adding comments into the post it valid in my opinion, especially in old questions where the chance of the OP to get back and do it himself is very low. On the other hand, I tend to reject minor format fixes on old questions (over a year in the past) as it's not reason enough to bump the question back to the front page so I would also have rejected this one probably adding reason "post too old to matter". –  Shadow Wizard Sep 4 '12 at 8:24
1  
@ShaWizDowArd Thanks for the hint to find a line to balance between "too old to matter" and "too messy for a Q&A site". –  Shegit Brahm Sep 4 '12 at 8:57

2 Answers 2

up vote 7 down vote accepted

To me the edits look reasonably legit and I would probably have approved them.

You may want to try and get the OP to edit their question first though. Leave a comment, favourite the question for later review, and teach the OP how to fish instead of handing one to them.

Not everyone reviewing is paying enough attention to see that you moved comments from the OP into the question. The review system is not infallible, and with only two reviews per pending edit there is plenty of scope for 2 people to misunderstand. I wouldn't trust their rep count in that regard either. :-)

You've made over 300 suggested edits, which only increased your chances to get a few misfire reviews. I wouldn't worry too much about these particular rejections.

share|improve this answer
    
Thanks for encouraging, but would you suggest that I re-edit the questions again in this case? And yes, I agree that 2 or 3 reviewers are not the community at all. –  Shegit Brahm Sep 4 '12 at 7:37
3  
Yes, I'd say the edit is legitimate enough. Personally, I'd even leave out the 'Edit:' header, perhaps. –  Martijn Pieters Sep 4 '12 at 7:39

Changing code in a question, when the asker says "This doesn't work", is really dangerous. You might accidentally fix the problem.

Changing brace placement is an ever bigger no-no. This is a semi-religious matter, where moving the opening brace from the end of one line to the beginning of the next, or vice versa, is about the worst thing you can do to a programmer. The code gets totally ugly!

That alone can be reason to reject an edit (if you do it the wrong way :-).

share|improve this answer
    
I agree to that religious matter of brace placement. I did not look all my reviews back, but I usually (with exceptions) move braces to a new line. Code: I definitly agree to change no character. In this case there was an opening "{" missing but concerning the comments this was not part of problem. It totally looked like "ooops lost in c'n'p" Otherwise the method would have thrown more and different errors than claimed. That is why I yielded to temptation this time. But I will keep brace placement in mind. –  Shegit Brahm Sep 4 '12 at 10:35

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .