What is meta? ×
Meta Stack Exchange is where users like you discuss bugs, features, and support issues that affect the software powering all 133 Stack Exchange communities.

If I write a piece of code / small program, and I'm concerned that I may not have done it in the best way possible and would like a peer review of the code, is SO the best place to ask that kind of question? Is that style of question beneficial to the community? Or does this need open up the possibility of another kind of SE site?

share|improve this question
1  
See also Where can I get a code review? –  Richard JP Le Guen Sep 9 '10 at 14:51

3 Answers 3

up vote 3 down vote accepted

Actually, these kind of questions pop up once in a while, under the form : "I want to do this and I managed to get it working using that code but I find my solution ugly/slow/..."

So I don't see a problem with that kind of questions, if formulated in a useful way. If you clearly state what you want to achieve, and you're sure you're not doing it the best way, why wouldn't you ask that question on SO? That's peer review as well.

OK, it's not the same as asking "take a look at my code and tell me what I could do in a different way" but then again, I'm not sure that's a good question to ask in the first place.

share|improve this answer
    
I think you have a point. Often the question is worded as 'I'm doing 'x' this way. Is this considered best practice or should I try do it with the 'y' methodology. –  Levi Hackwith Sep 9 '10 at 16:16

It is beneficial but i don't think it's what SO is for, code review is extremely subjective since we all do things differently, some may not approve of code style, variable names, optimization techniques, so on and so forth.

The best place for these kinds of questions is on a forum specialized, but not SO, it would create a lot of controversy.

share|improve this answer

I think that would be too localized; the answers would be literally only relevant to that code snippet.

It could also result in argumentative/subjective debates/discussions over coding style.

Maybe it would be an interesting Area 51 proposal, PeerCodeReview.StackExchange.com but I don't think it would fit with Stack Overflow.

share|improve this answer

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .