What is meta? ×
Meta Stack Exchange is where users like you discuss bugs, features, and support issues that affect the software powering all 131 Stack Exchange communities.

As you probably now there is an improved flagging system.

When you flag as:

it doesn't belong here

It shows you:

The 'This question does not belong here' menu

From which you can't go back to the original flagging menu.

I think it would be a good usability idea to put a link back to the flag menu there since you may want to see all your options before flagging in a certain way.

What do you think about this?

Thanks in advance!

share|improve this question
    
@Yi Jiang thanks for the edit, completely missed that tag! –  Trufa Jan 14 '11 at 15:01

2 Answers 2

Great idea - this will be pushed in tonight's deployment.

The area on the lower left of the dialog now says "back" instead of "cancel".

share|improve this answer
4  
The fact that you listen, makes me a proud member of this community. Thank you! –  Trufa Jan 18 '11 at 13:16

There's still a minor issue with the flag dialog, detailed in a related question that was mistakenly closed as a duplicate of this one. I think it can be resolved by making a few minor changes, though.

In the minified code, in the success handler c(A, x, y) for the AJAX call to get the close dialog after selecting the "it doesn't belong here" flag option, a click handler is assigned to the radio button that does not have name="existing-close". This handler calls g(E), which is responsible for turning the back/cancel link into a back link.

When it does this, it assigns another handler e() to the link which reverts those changes. Unfortunately e() turns the link into a cancel link, regardless of what it was before. Based on the code, it's possible that this is intentional, but it'd be nice if it could be changed given that the flag dialog seems to work fine either way.

So, what to do about it? One approach might be to save the original link instead of recycling it, e.g.:

var g = function (y) {
    // ...
    x.addClass("popup-active-pane").show();

    var c = y.closest("div.popup").find(".popup-actions-cancel");

    // Save the original link with handlers, and insert a clone in its place
    // No need for unbind on the clone since we cloned without events
    c.before(c.clone().html("back").click(function () {
        e(c);
    })).detach();

    window["pane" + w]();

    return true;
};

coupled with the following changes in e():

var e = function (c) {
    $(".popup-subpane").removeClass("popup-active-pane").hide();
    $("#pane-main").addClass("popup-active-pane")
        .show().find("input[type=radio]:checked").removeAttr("checked")
        .end().find("li.action-selected").removeClass("action-selected");
    $(".popup").find(".popup-submit").disable();

    // Check if we have a link to reuse (should be always)
    if (c) {
        $(this).before(c).remove();
    } else {
        $(this).html("cancel").unbind("click").click(function () {
            $(".popup").fadeOutAndRemove()
        });
    }
}
share|improve this answer
    
I just noticed this bug where the back button changes to the cancel button. Annoying to see that after 1 year this still isn't fixed. Your linked question shouldn't have been closed as it details a bug in the feature which was implemented due to the question in this thread. Too bad it was seen as a duplicate. Can't your question be reopened? –  Sicco Jun 25 '12 at 9:53

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .