What is meta? ×
Meta Stack Exchange is where users like you discuss bugs, features, and support issues that affect the software powering all 134 Stack Exchange communities.

I just approved an edit suggestion, or at least I thought I did. When I refreshed the page, the summary or audit page indicates that I actually rejected it and it appears that I was the only user required to do so!

   Apparently I rejected an edit


The edit was not to one of my posts, so I'm not sure why only one vote was required. But stranger yet was that I intended to approve the edit, not reject it. I thought I must have foolishly clicked the wrong button, but a visit to the recent activity in my profile shows this not to be the case:

  My recent activity, indicating that I approved the edit

The question also shows the edit was not approved, so it appears that only my profile that is out of sync.

What just happened? Is there a bug in the system, or did I just bugger up? It was a perfectly valid and necessary edit, and I hate to be the one to have rejected it, especially when I didn't intend to do so. Is there some way that the original editor could have canceled the edit, or someone else could have overrode their edit?

share|improve this question
    
We know what happened; we're discussing the best the way to fix it now. –  Jarrod Dixon Feb 15 '11 at 8:18
    
Also, you didn't do anything wrong (you voted to approve) - no buggering up was performed :) –  Jarrod Dixon Feb 15 '11 at 8:19
    
@Jarrod: Thanks for the update; that's reassuring. :) –  Cody Gray Feb 15 '11 at 8:19

1 Answer 1

up vote 3 down vote accepted

Here's what happened:

  1. anonymous user submitted a suggested edit
  2. Ted Hopp submitted his edit
  3. suggested edit was auto-rejected

Ted was able to submit because he had loaded the edit page before the suggested edit was created.

I've changed the auto-reject behavior to deletion: users with full edit privileges will have their edits saved, deleting any pending suggested edits and any approve/reject votes. This will only occur if the edit page was loaded before a suggestion exists.

This change is live.

As to your activity stream, it shows how you voted on a particular edit, not that it was the binding vote. I'm adding a tooltip on the approved or rejected text to help clarify this, e.g. hovering over rejected will display "voted to reject this suggested edit."

This tooltip change will be pushed out tomorrow.

share|improve this answer
    
@Cody - also, I've deleted the rejected suggested edit referenced in your question, unbuggering your activity timeline :) –  Jarrod Dixon Feb 17 '11 at 7:32
1  
Thanks for investigating this and providing such a thorough answer. The previous behavior makes sense once explained, and I agree with the modifications you've made. Although, I understood what the activity stream was showing, and I'm not sure that the tooltip would have mitigated my confusion (although it couldn't hurt). The problem was simply that the suggested edit page listed me as the sole rejecter when that wasn't the case. Either deleting the edit suggestion entirely (as you've done), or showing it rejected by Community would be more logical. –  Cody Gray Feb 19 '11 at 4:45
    
@Cody - we're still tweaking lots of things around suggested edits; better info around activity is coming! –  Jarrod Dixon Feb 19 '11 at 5:12

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .