Timeline for Code highlighting colors were changed. Intentional or not?
Current License: CC BY-SA 4.0
21 events
when toggle format | what | by | license | comment | |
---|---|---|---|---|---|
Feb 29, 2020 at 11:25 | comment | added | Greedo | The mobile and desktop versions seem to use a different colour palette, this is now extremely low contrast for VB languages on mobile (although they are fine on desktop) | |
Feb 26, 2020 at 23:31 | comment | added | Christian Rau | Ah, good to hear it's on the radar, though. Thank you. | |
Feb 26, 2020 at 23:30 | comment | added | Aaron Shekey StaffMod | @ChrissaysReinstateMonica There's a follow-up PR to fix that particular bug. Lots of moving parts today! | |
Feb 26, 2020 at 22:04 | comment | added | Christian Rau | Have you by any chance messed up some of the link colours with this fix? On sites where the link colours are starkly different from the button colours (like Movies & TV or Worldbuilding) the visited and hovered links suddenly have a very different colour (namely a tint similar to the button colour but evrry different from the normal link colour). | |
Feb 26, 2020 at 21:21 | history | rollback | Cody Gray |
Rollback to Revision 1
|
|
Feb 26, 2020 at 21:05 | comment | added | Martijn Pieters |
Ah, and .prettyprint is also left at the original #393318 . Any reason not to have used --black-800 there?
|
|
Feb 26, 2020 at 20:58 | comment | added | Martijn Pieters |
And the colors are lighter than I thought would be used at first. I agree with Dharman here, red-600 is too light. red-800 would be a lot easier on the eyes.
|
|
Feb 26, 2020 at 20:48 | history | edited | Aaron ShekeyStaffMod | CC BY-SA 4.0 |
Remove the image since folks are questioning its accuracy.
|
Feb 26, 2020 at 20:48 | comment | added | TylerH | @MartijnPieters That's part of the reason I added a list of the actual hex values; so people could look at what was objectively true for the design at a given point in time. Without that, the colors image in the post is even more useless/inaccurate than it is now as soon as the colors change again. | |
Feb 26, 2020 at 20:47 | comment | added | Martijn Pieters | I created a codepen comparing old and new, as well as a few alt styles using the same Stack colors. | |
Feb 26, 2020 at 20:41 | comment | added | Martijn Pieters |
@TylerH: the image is not actually accurate; the middle swatch is #8f2629 , not the actual red-600 (#c02d2e ) color used, for example. But it is consistently darker.
|
|
Feb 26, 2020 at 20:39 | comment | added | Martijn Pieters | @Dharman: the color image is a little darker from the actual CSS colours. | |
Feb 26, 2020 at 20:37 | comment | added | TylerH | @AaronSkekey it seems fair to remove the actual hex values so long as you also remove/update the image here any time the colors change. | |
Feb 26, 2020 at 20:35 | history | edited | Aaron ShekeyStaffMod | CC BY-SA 4.0 |
These hex values are subject to change and might not be accurate. These don't need to be included as part of this discussion, in my opinion.
|
Feb 26, 2020 at 20:26 | comment | added | Dharman |
The middle red is not in the stacks: stackoverflow.design/product/base/colors/#red Am I wrong? The red is now red-600 , but it would be better if it was red-700 or red-800 . Could it be changed?
|
|
Feb 26, 2020 at 20:23 | comment | added | Martijn Pieters |
Interesting, why is .typ not using a color variable though? It's still the original #2B91AF , or was it reverted in response to Cody's feedback?
|
|
Feb 26, 2020 at 20:17 | comment | added | JFoxx64 | The Stack Exchange SVG icon available for download uses #f48023 as opposed to --orange. The logo and the talent logo's both have the correct color. Seen a lot of changes in color popping up. figured I would bring it up here, rather than make a question over such a minuscule lack of blue. | |
Feb 26, 2020 at 20:02 | history | edited | TylerH | CC BY-SA 4.0 |
Added concrete values for the new colors based on stacks.css to clear up confusion (see https://chat.stackoverflow.com/transcript/message/48698297#48698297)
|
Feb 26, 2020 at 19:28 | comment | added | Cody Gray | I think this is, on balance, an improvement. I'm glad you worked hard to keep the closest colors to the old scheme as possible. The effort shows. My primary concern here is with the fifth color from the left. It used to be a very saturated deep blue, closer to purple than to green. Now it's a very desaturated dark blue, closer to green than to purple. That would be fine in the abstract, but in practice it is too close to the color right next to it. Since these colors get used for keywords and user-defined types in code, which often occur adjacently, being able to distinguish them is important! | |
Feb 26, 2020 at 17:20 | vote | accept | HolyBlackCat | ||
Feb 26, 2020 at 17:06 | history | answered | Aaron ShekeyStaffMod | CC BY-SA 4.0 |