18

I was looking through some old questions trying to find bad answers to fix for editing and flagging and I came upon Stack Overflow question Closing a modal box with an iframe inside the iframe.

It completely breaks the Stack Overflow layout. I can't even see the entire question to flag to mods attention. When I checked the same question in different browsers I got a message:

We're sorry...

There are an unusual number of requests coming from this IP address.

To protect our users, we can't process any more requests from this IP address right now.

We'll restore access as quickly as possible, so try again soon.

If you believe you have reached this page in error, contact us.

Can a moderator review it to fix the issue?

This is happening in Chrome, Firefox, and Safari. So it has to be something in the code in the question.

9
  • 1
    It's iframes all the way down. Commented Jun 8, 2012 at 12:11
  • I figured it was something like that, but I can't edit it. It is hidden in the frame.
    – Taryn
    Commented Jun 8, 2012 at 12:11
  • Yeah, I can't get to any edit or delete link either. Commented Jun 8, 2012 at 12:13
  • 2
    @BilltheLizard You guys. Just go to the edit route directly. :)
    – Adam Lear StaffMod
    Commented Jun 8, 2012 at 12:14
  • 1
    I can...but I do not dare to fix it. :) Commented Jun 8, 2012 at 12:15
  • 1
    @AnnaLear I did, but this crazy "Anna Lear" person beat me to it by seconds. :P
    – Tim Stone
    Commented Jun 8, 2012 at 12:15
  • 9
    @TimStone Oh my god, she's so annoying.
    – Adam Lear StaffMod
    Commented Jun 8, 2012 at 12:16
  • 1
    woah. trippy. stackception, etc. i.sstatic.net/RJ4Fl.png
    – tombull89
    Commented Jun 8, 2012 at 12:16
  • 3
    @AnnaLear You and your fancy address bar incantations... Commented Jun 8, 2012 at 12:17

2 Answers 2

12

Looks like a code sample gone wrong. I fixed the formatting on it and all's right with the world again.

balpha's answer covers the rest.

3
  • Shouldn't the iframe stuff be escaped somehow? It looked like the post actually rendered those (until it failed somewhere). Commented Jun 8, 2012 at 12:18
  • @MadScientist Yeah, it did. I had no idea we allowed <iframe> tags. We probably shouldn't. (And apparently we don't, since it's been 3 years since that question was posted. :))
    – Adam Lear StaffMod
    Commented Jun 8, 2012 at 12:19
  • 1
    thanks for fixing it so fast. for a second I thought I broke SO...not really. :)
    – Taryn
    Commented Jun 8, 2012 at 12:52
12

Apparently back in 2009 when this answer was posted, the sanitizer wasn't... quite sane. Since the HTML is only generated on edit, you were looking at the HTML generated back then. A no-op edit would have fixed that (but of course Anna's edit made more sense in this case).

You can see at https://stackoverflow.com/revisions/1139354/2 (which is always rendered on the fly) that this issue has been fixed since then, so these days, this won't happen happen anymore.

The above is the usual answer for cases like this, but in this cases, it's not true. This was actually a current bug in the link-rot remapper. Fixed now.

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .