13

I have a doubt that this is real:

Title marked as removed

Either the display is buggy or the title validation is buggy. Or my monitor is really buggy. Or my brain, but you can't fix that.


Update

The edit was eventually approved, and appears to contain no real title change. This gets the Markdown diff into trouble, then...

7
  • 1
    I have noticed several variations of this; it seems title changes don't work quite as expected. Jan 27, 2013 at 4:57
  • I vote for "all of the above". But yeah, looks like the diff forgot about retagging.
    – Shog9
    Jan 27, 2013 at 4:59
  • 1
    And 2 out of 4 did reject this edit -- like I would, unless I doubted the display. So, this surely will make reviewers make the wrong decision. Sounds like an urgent bug to me.
    – Arjan
    Jan 27, 2013 at 7:28
  • (As an aside, for image alt text fun, please use title instead? We do have people using screen readers on these sites. The many default "enter image description here" alt texts are probably already annoying for them, but I assume using title can be handled better by a good screen reader. Cheers.)
    – Arjan
    Jan 27, 2013 at 7:33
  • is tagged as status-completed, but I'm seeing lost of weirdness in the Suggested Edit diffs this evening.... either titles showing as removed as the OP mention, or no diff showing for Title-only changes. Was this fix actually deployed? Jan 27, 2013 at 9:59
  • @psubsee2003: See comments on balpha's answer. Jan 27, 2013 at 10:00
  • @LightnessRacesinOrbit Thanks, I didn't see those comments when I started typing. Jan 27, 2013 at 10:01

1 Answer 1

6

Spot the mistake :)

public bool HasTitleEdits { get { return SuggestedEdit.HasTagEdits; } }

Fixed in the next build.

6
  • 1
    It seems like now, proposed edits that only change the title show no diffs at all. Before the fix, I hope.
    – Bo Persson
    Jan 27, 2013 at 9:56
  • Yeah, this isn't rolled out yet. I'll do that now; should be correct in a few minutes.
    – balpha StaffMod
    Jan 27, 2013 at 9:58
  • Lulz. Also interesting to get a glimpse into how the highlighting is done -- when HasTitleEdits is true, it does a diff and falls back on just highlighting everything if it can't find a localised change? Jan 27, 2013 at 9:58
  • 1
    As an aside, is there perhaps a "status-sort-of-completed" tag for fixes that have been committed but not yet deployed? Jan 27, 2013 at 10:01
  • 1
    @LightnessRacesinOrbit Re your first question -- a suggested edit that doesn't change the title doesn't store the title at all. Thus when creating a diff because of an incorrect HasTitleEdits, it creates a diff between the original title and an empty one, which is what you saw. Re your second question -- no.
    – balpha StaffMod
    Jan 27, 2013 at 10:04
  • Good answers :) Jan 27, 2013 at 10:39

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .