10

MSO votes activity tab in my profile doesn't show closure and reopen votes sub-tabs. Is that OK?

For comparison, votes tab in my SO profile shows mentioned sub-tabs. Comparison screen shot is below.

http://i.stack.imgur.com/8wJXe.png

  • 2
    Presumably this is because they're no longer "votes", but it'd be nice if they still had tabs there. – Tim Stone Jun 23 '13 at 21:53
  • @TimStone - Pretty much the reason (that and some hairy code paths that need some work). – Oded Jun 24 '13 at 11:26
2
+50

look!

closure and reopen are back, as if they never went away.

Let me know if you find any bugs there.

  • 1
    All the votes are listed as "undovote", and have the wrong timestamp, but otherwise it looks good ;) – Tim Stone Jun 24 '13 at 14:58
  • Also expired votes should be marked as such, under the action name, if we're aiming to be consistent with the original implementation. – Tim Stone Jun 24 '13 at 15:03
  • @TimStone - How does it look now? – Oded Jun 24 '13 at 15:23
  • 1
    The timestamps are still wrong, but otherwise it looks good (although "closure" is inconsistently coloured as maroon, but it looks like that's intentional?) – Tim Stone Jun 24 '13 at 15:25
  • Whoops, scratch the bit about the inconsistency, I was only comparing between the two tabs and failed to see that "delete" and "closure" were indeed consistent. So, only the timestmaps. – Tim Stone Jun 24 '13 at 15:36
  • 1
    @TimStone - Give it 5 for the timestamp issue. – Oded Jun 24 '13 at 15:36
  • Looks good, thanks! – Tim Stone Jun 24 '13 at 15:41
  • 1
    all votes in my activity -> closure sub tab say "(deleted)", even those where clicking the question link clearly shows me among those who closed it. But anyway, that's quite a relief to see them back! – gnat Jun 24 '13 at 17:19
  • @gnat - do you mean under votes -> closure? There is no activity -> closure on Meta. – Oded Jun 24 '13 at 17:24
  • @gnat - I think the (deleted) means that they have aged (not sure, though), something new. – Oded Jun 24 '13 at 17:26
  • 1
    @Oded yes, votes->closure. "(deleted)" means just this - aged votes, in my experience it was also shown in cases of reopen. Thing is though, it doesn't look like applicable in some examples I've seen. Eg this one: my vote was cast on Jun 21, question has been closed the same day, 338 views since March suggest it wasn't highly viewed, not enough to age my vote; and, well, I am listed among close voters there, and it's not reopened – gnat Jun 24 '13 at 19:50
  • @Oded per my observation upon CVs cast during last 3 hours, "(deleted)" in MSO closures sub-tab isn't displayed only for questions that aren't yet closed. That certainly differs from the way it is in my profile pages at Programmers and SO – gnat Jun 25 '13 at 11:12
  • 1
    @gnat - OK. I have an idea about the cause. Need to figure out a good solution though. – Oded Jun 25 '13 at 13:42
  • @Oded I just discovered a detailed explanation of that deleted - What causes close votes to be annotated with “(deleted)”? Per my reading it's an accepted bug / status-by-design (meaning apparently will-not-fix). To avoid misunderstanding, I don't complain, merely point this for the record. I think I got used to that bug :) – gnat Jul 17 '13 at 23:48

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .