Circular duplicate link allowed

Question

Circular duplicate links didn't used to be allowed, but I just did it:

question one

question two

@FDinoff yes, I undid it since I didn't actually want the circular reference to stay. If you look in the revision history you should see it. — nhinkle, Jul 1, 2013 at 3:21
@JarrodDixon I swear I was stopped once from making a circular reference, but maybe I'm conflating that with it stopping me from marking as a duplicate of a deleted question. Either way, could you make it status-planned if that's appropriate? — nhinkle, Jul 1, 2013 at 3:35
No, the code used to be there, but most of the flagging/closing code was refactored. Part of the plan was to implement Tarjan's algorithm for finding circular dupes. — Jarrod Dixon, Jul 1, 2013 at 3:37
@Undo it's a userscript that one of the SU mods wrote that copies the superping string for each user who voted to close a question. We use it to send reminders via chat to users who vote to migrate questions to SU that don't belong there. — nhinkle, Jul 1, 2013 at 3:47
@JarrodDixon with the automatic redirect for anonymous users on duplicates, what happens when there's a circular reference? — nhinkle, Jul 1, 2013 at 3:48
We get an exception in our logs. And I am deprived of my dinner. — Jarrod Dixon, Jul 1, 2013 at 3:51
@JarrodDixon I'm glad to hear that they take these things seriously over there. What happens to the user? "Oops, something went wrong" or "infinite redirect loop"? — nhinkle, Jul 1, 2013 at 3:54
Possible duplicate: meta.stackexchange.com/questions/54024/… — Mateen Ulhaq, Apr 2, 2018 at 5:06

Community · Accepted Answer · 2017-05-23 12:36:23Z

9

Alright, I've added some protection against this via a neat library that danielrbradley created.

There's sure to be some issues (which we'll log when a block occurs), but the base cases are covered (and unit tested, oh my!).

CommunityBot

1

answered Jul 1, 2013 at 5:39

Jarrod Dixon

38.1k4 gold badges129 silver badges162 bronze badges

That was speedy! Thanks.
– nhinkle
Jul 1, 2013 at 5:43
It was a regression that was totally my fault - I couldn't go home and leave it borked :)
– Jarrod Dixon
Jul 1, 2013 at 5:45
1

Now the check is bit too strict. :/
– Shadow Wizard Chasing Stars
Jul 2, 2013 at 10:56
FYI there is another regression.
– Shadow Wizard Chasing Stars
May 11, 2016 at 14:59

Add a comment |

1 Answer 1