Who broke the Badges page?

Question

The sidebar on the Badges page is being pushed down:

broken page

Here's the person responsible.
– hjpotter92
Jul 9, 2013 at 7:58 — hjpotter92, Jul 9, 2013 at 7:58
@hjpotter92 The wheel is outdated.
– Antony
Jul 9, 2013 at 8:00 — Antony, Jul 9, 2013 at 8:00

Sklivvz · Accepted Answer · 2013-07-09 09:00:22Z

8

It's all my fault, but I have fixed it :-)

The missing </div> was only an effect of a flunked Reshaper refactor (invert if to remove nesting).

This lead to the last bit of HTML inside the badge render loop to be skipped for single badges and this element was the missing </div>.

It will be out in the next deployment.

answered Jul 9, 2013 at 9:00

Sklivvz

36.3k12 gold badges98 silver badges159 bronze badges

1

Does it also apply to the bronze badges appearing unformatted from continuous-integration?
– fedorqui 'SO stop harming'
Jul 9, 2013 at 9:04
1

Yes, and ouch! that's terrible.
– Sklivvz
Jul 9, 2013 at 9:06

Add a comment |

Mołot · Accepted Answer · 2013-07-09 07:44:08Z

17

Latest FireFox with firebug shows: Looks like missing </div> in a loop somewhere, I don't see <div class="badge-hierarchy"> to end.

enter image description here

answered Jul 9, 2013 at 7:38

Mołot

7,8682 gold badges28 silver badges54 bronze badges

Add a comment |

Community · Accepted Answer · 2017-03-20 10:31:02Z

9

The fun part: Mołot's finds in Firefox's 3D View!

(Each 3D surface represents a HTML element with a color-coded edge: the teal ones are divs)

An ever-deepening pile of divs

CommunityBot

1

answered Jul 9, 2013 at 8:02

doppelgreener

33.8k8 gold badges81 silver badges168 bronze badges

Add a comment |

3 Answers 3