30

I did some First Post Reviews today and eventually got this question as an audit C++ What optimizations do compilers still struggle with?

It has 20 upvotes but it's (rightly) closed as not constructive.

I wanted to flag it as "primarily opinion based" but when I clicked on flag, I failed the audit: image of failed audit

Since I'm still somewhat new to reviewing I what to make sure I get it right in the future. Is this audit defective or was flagging actually the wrong approach?

Improve this question
9
  • 17
    The audit is definitely defective.
    – Martijn Pieters
    Jul 18, 2013 at 12:29
  • 2
    +1 I think I failed that a few days ago by daring to try and comment.
    – michaelb958--GoFundMonica
    Jul 18, 2013 at 12:29
  • 3
    I probably would have failed that audit too. Good thing I don't do reviews, I guess.
    – George Stocker
    Jul 18, 2013 at 12:35
  • 2
    looking at it...
    – m0sa StaffMod
    Jul 18, 2013 at 12:36
  • 3
    an excellent case to support recent feature request to deal with incorrectly picked audits: Review audits and “I understand” button
    – gnat
    Jul 18, 2013 at 12:46
  • Using such controverse close candidates as audits is perverse. Possibility to close questions which were asked before new rules were applied keeps me away from close votes queue.
    – Danubian Sailor
    Jul 18, 2013 at 14:20
  • Probably don't need manual feedback to detect closed questions, @gnat.
    – Shog9
    Jul 18, 2013 at 14:29
  • 3
    @Shog9 well as an example, with fix that crap button, that particular bug would be discovered earlier and with less meta hassle - just note comment above "I think I failed that a few days ago by daring to try and comment". The smoother is bug reporting the faster is their detection and fix
    – gnat
    Jul 18, 2013 at 14:45
  • How come such an old post appear in the First Posts review (even if it's an audit)?
    – Old Checkmark
    Jul 25, 2013 at 13:00

1 Answer 1

Reset to default
10

Fixed and rolled out in build 2013.7.18.862. Closed questions are now excluded from known good post audits in the first posts review queue.

Improve this answer
1

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .