Today I viewed this question which seemed appealing. But once viewed the PHP code I began to cry like there was no tomorrow. The code made use of __get
and __set
magical method in a situation where the was no real need and made it somehow recursive to the point that even the PHP error message didn't make much sense.
I've hardly seen a code worse than that one in at least 3 months, so my first reaction was to comment with:
My eyes are bleeding.
After a while I came back to the question and noticed that my comment was gone. I thought about it and understood why it was deleted: it was not constructive (even though I'm most certainly positive I've seen exceptions to this rule multiple times). And I totally agree with that action.
So I reposted my comment in the form of:
My eyes are bleeding. No, but seriously: [about 3 lines of comment explaining why he shouldn't have used
__set
and__get
in the first place].
So that it contained an hint on how bad that code is and the explanation as to why.
Surprisingly enough I was linked back to that question and noticed that my comment was edited: the first part was completely removed leaving the comment as:
Seriously: [about 3 lines of comment explaining why he shouldn't have used
__set
and__get
in the first place].
Here's my question: is this considered going too far into "fixing" comments? Should I avoid anything that is not extremely constructive (if so, should I flag every "Thanks" or "RTFM" comments as well as variation of "My eyes are bleeding", "My brain hurts" and such?)?