25

I recall this review:

enter image description here

It was one that I knew could use a bit more spit and polish, but I didn't have the inclination or energy to edit it myself, so I skipped it.

I wander my way over to Suggested Edits Dashboard (10K only), and look at the listing...

enter image description here

...so, when did I approve this again? I skipped the question; that doesn't mean I gave my tacit approval, does it?

Seems like the dashboard needs to agree with the suggested edits view.

  • Looks like it's displaying all users who took action on that item - no matter what type of action. – Shadow The Dragon Wizard Nov 28 '13 at 19:51
  • It was reported before but since this report is much better voting to close the older one as dupe of this. – Shadow The Dragon Wizard Nov 28 '13 at 19:57
  • Just stumbled across the same. Skipping a suggested edit is listed as approval in the list view. Probably a trivial error in the underlying SQL. – Erwin Brandstetter Feb 19 '14 at 23:54
9

Fix is rolling out with build rev 2014.12.1.2057 to sites, thanks to this recent question which brought the issue to my attention.

6
+25

The current format is:

Approved/Rejected by [people who took any action including skip]

It isn't ideal, but once you understand all the people listed did not agree with the outcome, it's workable. It's not a huge issue either since this is pretty easy to understand despite the confusing wording.

However, it would be best if it said:

Approved/Rejected by [people who reviewed according to outcome], Rejected/Approved by [people who reviewed against the outcome], skipped by [those who skipped]

(Bold to indicate it was the actual outcome)

But even this would be a quick & easy improvement:

Approved/Rejected, reviewed by [people who took any action]

Skips are probably not something useful to know so it might be better to leave them out of there completely.

  • 2
    I think skip shouldn't be public. It's not visible anywhere. – Shadow The Dragon Wizard Mar 11 '14 at 23:38
  • @Sha except your own review history after 10k (for whatever reason) – 3ventic Mar 11 '14 at 23:53
  • I still think it's a bug, some kind of overlook on the dev's side. – Shadow The Dragon Wizard Mar 11 '14 at 23:54
  • @sha might be, and if so, removing it makes sense. – 3ventic Mar 11 '14 at 23:55

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .