12

When you are using the 10k tools to review flags, you get the following dialog:

Flag Dialog Shrunk

If you click on the "Flag or Disagree" option, you get the following options:

Flag or Disagree Dialog

If you expand the post out and click on flag:

Expanded Flagged Post

You get a more limited set of options despite being in the review dialog:

Flag Dialog

Since you are in the review dialog, clicking on that "flag" option should also give you the ability to disagree (select 'invalid flag').

  • 1
    How would you know there is a flag to say is invalid? – Lance Roberts Jan 6 '14 at 1:52
  • 5
    @LanceRoberts: Because he's looking at the post on the flagged posts review page? Every post there has been flagged, that's the whole point. – Ilmari Karonen Jan 6 '14 at 2:01
  • @IlmariKaronen, ok, entering it from that point-of-view, but what if he entered the question flagging dialog from the question. I thinking they may not want to track where you entered the 'flag from a post' dialog from. – Lance Roberts Jan 6 '14 at 2:06
  • 1
    @Lance, I am not asking for the flag dialog on the question to show that option, only that the flag dialog in the flagged posts review shows the option. And yes, I'm sure they are just using the question flag dialog options there right now, which is the source of the confusion, but it would be better for the flagged posts review dialog to show consistent flag dialogs regardless of which "flag" option you click. – jmac Jan 6 '14 at 2:09
  • @LanceRoberts: Then they'll presumably decline this feature request, since that's pretty much exactly what it's asking for. (Note, however, that each post on the flag review page already has a button that does bring up the dialog with the "disagree" option; it shouldn't be hard to write some JavaScript to intercept clicks on the "flag" link and redirect them to the button. In fact, I could probably whip up a user script to do that pretty easily...) – Ilmari Karonen Jan 6 '14 at 2:09
  • @Ilmari, if you can write a user-script to do it easily, it should be an equally easy fix on their side to do the same. Hence the request. I don't see why it would be declined (the request makes sense), though I can see it being very low priority (which is fine by me) – jmac Jan 6 '14 at 2:11
8

I did some digging into the HTML, and here's what I found:

The "flag or disagree" buttons on the flagged post review page have the class attribute:

class="flag-post-button show-invalid"

while the "flag" links on the posts themselves have the attribute:

class="flag-post-link"

I had an idea, and decided to see what would happen if I used developer tools to change that to:

class="flag-post-link show-invalid"

and what do you know? It works!

Screenshot of flag dialog with "invalid flags" option shown

The only remaining tricky bit, from a user script viewpoint, is that the expanded posts (including the flag links) are loaded using AJAX, so I'd have to hook into the loading process somehow to add the extra class name. Presumably, this would be somewhat easier for the SE devs, since they actually have direct access to the code without having to hack it.


Ps. I did a bit more testing, and it turns out that this trick seems to work on any flag link, even in the normal question view, and even here on meta where I don't even have 10k yet(!). I just gave this question an "invalid flags" flag to see if it would go through; looks like it did:

Screenshot of "invalid flags" flag

My apologies for any potential confusion this may cause to the mod who ends up handling it. ;-)


Update: Here's a working user script to implement this feature, pending a proper fix from the devs. The actual code is pretty simple:

$('.mod-post-header').on(
    'mouseover',
    '.flag-post-link:not(.show-invalid)',
    function () {
        $(this).addClass('show-invalid');
    }
);

Instead of trying to hook into the AJAX code to attach the extra class name when the questions are expanded, this code simply uses jQuery's delegated even handling to insert it at the last moment when you move your mouse over the link to click it. I think it should work on touchscreens too, but I haven't tested it yet.

  • 2
    Awesome work. Thanks for the effort, and hopefully to make it easier for the devs to fix when they get around to it! – jmac Jan 6 '14 at 2:28
  • 9
    Hahaha yes. I came to this post and was like "what the hell is invalid?" – animuson Jan 6 '14 at 2:41
  • Well that's a massive bug you've found there Ilmari. Hope that gets fixed up all quick-like! – jmac Jan 6 '14 at 2:59
  • @jmac: Fixed. – Ilmari Karonen Jan 7 '14 at 20:41
4

I thought I'll implement this since I was already digging around in that part of the woods.

Will be with you in build 2013.1.7.1824 on meta and 2013.1.7.1278 on sites.

  • Nope, such thing does not exist. I just checked a random answer that got NAA flag and the answer's flag dialog has no "it has invalid flags" option. Am I missing something? – Shadow Jan 26 '14 at 13:29
  • I just tried the same thing - flag an answer from the answer and there is not an "invalid flags option". – chue x Apr 3 '14 at 14:20
  • @chuex Are you trying to dispute a flag on the question from an answer or on the answer itself? – Adam Lear Apr 9 '14 at 22:28
  • @anna My comment above refers to disputing a flag on an answer from the answer itself. The workflow is this: I see a flag in the 10k queue (e.g. not an answer), and then go to the answer to investigate. I conclude that the NAA flags are invalid. I click on the flag link from the answer, and don't see the "invalid flags" option. However, when I click the flag link from the 10k flags queue, I do see the "invalid flags" option. My understanding is that m0sa's fix makes the "invalid flags" option appear in both places. – chue x Apr 9 '14 at 23:39
  • @chuex Hmm. This might be a moot point soon since the 10k tools are going away altogether. Not 100% sure how this is supposed to work in that case. – Adam Lear Apr 9 '14 at 23:41
  • @AnnaLear Yes with the 10k flag tools going away, I'm not sure how relevant this all is. I originally had flagged the question above to just get the [status-completed] tag removed. I believe jmac's issue is the same as what I describe (inconsistent flag options); m0sa's change, as I understand it, is supposed to fix this. – chue x Apr 9 '14 at 23:51
  • @chuex This is probably not worth revisiting either way with the queue going away. The gory details of how that's going to work are here. Thanks for keeping an eye out for things potentially regressing, though. It's appreciated. :) – Adam Lear Apr 10 '14 at 0:12

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .