6

While reviewing late answers, I attempted to edit a poor answer by opening the editor in a new tab, and was faced with a notification that the post had been deleted.

If the post was deleted, the correct action is pretty clearly to do nothing, yet when I selected "No action needed" this message was returned:

STOP! Look and Listen.

Note that I did attempt to edit the post as suggested by this message, but was blocked from doing so while given no credit for trying.

Additionally, there is rogue semicolon at the end of this error message...

  • 3
    You passed! We occasionally insert rogue semicolons in site messages to make sure you're really paying attention. – Andrew Cheong Jan 28 '14 at 19:29
  • I'm confused here - were you actually able to open the editor? Clicking edit should have passed the audit immediately. – Shog9 Jan 28 '14 at 19:33
  • I was not able to open the editor. I clicked to edit and I got an empty page with just plain text stating that the answer no longer exists. Following that, I navigated back in the browser and clicked no action. – Dan Jan 28 '14 at 19:34
  • 1
    @Dan Then I think the error is that the message isn't loading properly. If it was a review audit, the post was already deleted. It wasn't deleted while you were reviewing. – animuson Jan 28 '14 at 19:41
  • Ah... Do you normally open the editor in a separate tab? – Shog9 Jan 28 '14 at 19:41
  • Honestly, I don't recall what I did in this particular instance. In general though, I would not open it in a new tab and I'm about 80% sure I didn't in this case. I do use tabs quite a bit though, so possible. – Dan Jan 28 '14 at 19:43
  • @animuson Sure. That doesn't really change the problem at hand though. – Dan Jan 28 '14 at 19:44
  • 4
    The only way I can reproduce this is to open the editor in a separate tab (right-click the edit link, open in new tab or window). Unlike the inline editor, this fails to complete the audit (and will generate an error if you can't edit deleted posts). – Shog9 Jan 28 '14 at 19:51
  • @Shog9 That must be it then. Thanks for clarifying. – Dan Jan 28 '14 at 19:51
  • 2
    Related (about the semicolon): Typo on the Close Votes review audit failure message – michaelb958--GoFundMonica Mar 30 '14 at 4:37
  • @Shog9 I have noticed that sometimes when I try to edit posts from the review I am not brought back to review, and that I need to open in a new window. maybe I should post that in meta next time I come upon that issue? – Malachi May 5 '14 at 12:35
3

Here is the trick. You are thinking "oh, it's already deleted, no further action is needed." But the audit is saying "pretend this exists and hasn't been deleted. What would the right action be?"

When you look outside the review queue and discover the post is deleted, that's a big clue that it's an audit, and that the right action would be to recommend deletion. I think flagging, closing, editing and commenting (from the review UI, not in your own tabs) will also pass the audit at that point. You are not shown items in the review queues that have already been deleted in any context other than an audit. Audits are pretending to show you real posts, but are in fact showing you non-real posts - deleted ones, or ones that have been faked up in some other way - and asking for your ruling on them if they were real.

  • Yes, I understand all of that. That doesn't make this any less of a bug. Me opening the editor in another tab should not behave differently than me opening it in the same tab. If that is impossible to implement, then it should be documented that new tabs cannot be used. – Dan Jan 28 '14 at 21:29
  • I don't think you do understand if it you clicked No Action Needed. That's what caused you to fail the audit. You can use the new tabs to gather information, but actions you take there can't be caught by the review counting and auditing mechanisms and I am not sure anyone expects that they should be. – Kate Gregory Jan 28 '14 at 21:42
  • 2
    I clicked no action because when I tried to take an action (Edit) it threw an error... – Dan Jan 28 '14 at 21:44
  • I had the same thing happen to me, except it was a "First Post" review, and I clicked the edit link within the review and the same things happened. if that message is supposed to tell me that it was an audit it should just say so and tell me good job but we need you to down vote or whatever – Malachi May 5 '14 at 12:33

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .