Ignoring sponsored tags doesn't work

Question

Since Adobe tags (which I'm totally not interested in) now are screaming for attention with colorful icons, I tried to add them to my ignored tags. They are added to the ignored list, but the questions containing them are not actually displayed with the changed style. (Example: "actionscript")

Directly after adding a tag it seems to work, but after a reload questions with the tag stop being marked as ignored.

Answer 1

This is fixed and will be rolled out in tomorrow's push.

The new image added a space when jQuery's .text() was called, so I wrapped that call in a $.trim.

I <3 jQuery!

Answer 2

Edit: workaround, use wildcards. Remember that the extra space at the start is blocking the match, so enter *flash to block flash, *actionscript-3 etc.

Answer 3

It looks like the bug is in the getTagsSelector() function, when the text is obtained for tags with embedded images there is a leading space, resulting in a class of ".t- flex" (rather than ".t-flex", I threw together a GreaseMonkey script to test removing the space and it seems to work.

i.e. replace:

if(d){
    b+="div.tags:regex(class, t-"+a.replace(/\*/g,".*")+"),"
} else{
    b+="div.t-"+a+","
}

with:

if(d){
    b+="div.tags:regex(class, t-"+a.replace(/\*/g,".*")+"),"
} else{
    b+="div.t-"+a.substring(1)+","
}

There is probably a neater way

Answer 4

If it's part of the ad terms/contract to have the tag not hidden even if it's listed on a user's ignore list, it's branding and advertising to an uninterested crowd.

Which is missing the point of the ignore/hidden tags. If they have no interest in seeing the tags, why would they now want to see the tag with sponsorship?

Forces it down the throat of the wrong market. The targeting has failed in this case.

Answer 5

I know this has already been fixed, but I just ended up fixining it on my own StackExchange... I also rewrote the getTagsSelector() function to be a little more streamlined. Perhaps Jarrod will learn to love jQuery a bit more:

function getTagsSelector(jPrefs) {
  var replacements = {
    '#': 'ñ',
    '+': 'ç',
    '.': 'û'
  };
  // jPrefs is a jQuery set
  return jPrefs.map(function() {
    var tag = $(this).text().replace(/(\s+|\xa0|#|\+|\.)/g, function(match) {
      if (replacements.hasOwnProperty(match)) return replacements[match];
      return '';
    });
    if (tag.indexOf('*')>-1) {
      return "div.tags:regex(class,t-"+tag.replace(/\*/g, ".*")+")";
    }
    return "div.t-"+tag;
  }).get().join(",");
}

EDIT noting Jarrod's comment about   not being matched by \s - I added \xa0 to the match for replacements