8

It seems that the parsing of tags with plusses (+) in them broke recently. This is very inconvenient for topics like C++.

See these questions tagged with c++: "[c++]". Now, if you select another tag from the list on the right, such as "templates", it used to bring you to "[c++] [templates]". However, as of fairly recently (somewhere in the last month or so), it started bringing you to "[c+++templates]". It appears that the space in the URL (encoded as %20) has been replaced by a +.

This is especially weird for tags that have a + in the middle, like c++11. If you go to "[c++11]", and again select "templates" on the right, it breaks down into "[c] [11] [templates]".

It seems that the thing that generates the search URLs is missing a URL encoding step.

5
  • What's your Web browser? Jan 31 '18 at 22:42
  • 2
    I repro-ed this on Chrome
    – rene
    Jan 31 '18 at 22:46
  • Going by archive.org, looks like this has been broken since at least the 26th. Thanks for the report!
    – Shog9
    Jan 31 '18 at 22:50
  • 1
    Related bug on MSO: meta.stackoverflow.com/questions/362508/…
    – Shog9
    Jan 31 '18 at 23:17
  • This will be my fault; I've been overhauling that code as part of a new feature - I obviously missed a key scenario. It will be rectified. Jan 31 '18 at 23:21
5

This should now be fixed; sorry about that.

Edit: well, I fixed half of it: the tags on the right should work fine, but now switching tab is unreliable with tags like C++ - working on that too!

(and: done)

7
  • But what went wrong? Feb 10 '18 at 13:21
  • @ShadowWizard it turns out the code was meant to be "right"; instead it was "not right" :) more specifically, there's some subtle things that happen on how + is treated depending on whether a URL is %-encoded or not; i.e. without other characters being %-encoded, + can be used for space - but with the %-encoding it needs to be %20 instead Feb 10 '18 at 14:34
  • Ouch, sounds complicated and delicate... kudos for fixing! Feb 10 '18 at 20:23
  • Seems semi related - but I've just wanted to merge a couple of tags with a + in them on SO and had to hand wrangle the URLs for those to work. Picking another two for an example (not actually doing anything with them! (C++ and C++14)) I get a url of: mastertag=c%252b%252b%2b&removetag=c%252b%252b14 and told that: c2b2b14 will be removed from 0 questions and c2b2b+ will be added to 0 questions.... it's hardly a common operation and can be gotten around easily enough - just a wee bit inconvenient... Feb 19 '18 at 17:10
  • @JonClements yup, something broke; looking Feb 19 '18 at 17:12
  • @JonClements fixed next build Feb 19 '18 at 17:16
  • Glad it was a quick fix. Thanks mate. Feb 19 '18 at 17:18

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .