First off, I gotta note: the core suggested edit logic is really old - it dates back to early 2011. It was updated a bit back in '12 to allow integration with the then-new review system, but it's still kinda separate and... Well, it does things a bit differently.
So with that in mind, here's what happened...
- The editor submitted two edits simultaneously. Well, probably not exactly at the same time, but close enough; who knows how that happened, maybe they double-clicked, maybe their network hiccuped... Anyway, two in-flight requests for the same exact edit.
- This ended up creating two suggested edits on the same post, for the same revision, at the same time (07:48:00). For the sake of discussion, let's call those edits 21773 and 21774. What, they're nice names. I have a niece named 21774, named after my uncle, ol' 21 "Bob" 773. Also those were the actual database IDs.
- Along with the suggested edits, those simultaneous requests created two review tasks, one associated with each edit. Now things start to get weird...
- At 12:55:14, you opened this review task which was associated with edit 21774; at 12:55:55, you submitted a rejection. Because you're a moderator, that immediately rejected the associated suggested edit. End of the line for poor 21774.
- The suggested edit logic assumes there'll only ever be one pending suggested edit on a given post at a time, and only one active review task - so it doesn't bother keeping track of which task you were actually reviewing; it grabs the first pending review task it can find for the post, and attaches your review to it. It grabbed this task, associated with edit 21773 which had already been reviewed by wbogacz, and attached your rejection to it. This also marked the review task completed.
- Now there's only one suggested edit left pending (21773) and only one pending review task (this one), and they don't match.
- At 13:14:42, a scheduled task runs, notices that the suggested edit associated with the outstanding review task has been rejected, and invalidates the task. All that remains is one outstanding suggested edit, with no associated review tasks.
- Ah! But there's another scheduled task that exists for the sole purpose of finding orphaned suggested edits and adding review tasks for 'em! It runs at 14:00:00, finds 21773 hanging around, and creates this task for it. It helpfully backdates the new task to the creation time of the edit, thus ensuring I spend a good 20 minutes tearing out what little hair remained on my head before finding it.
- At 15:40:34, mattm submits an approval for this new task. Suggested edit logic still doesn't think there'll ever be multiple pending edits for a post, much less multiple tasks for a single edit... So it counts all of the reviews associated with all of the tasks associated with this edit. Since wbogacz had already approved it previously, mattm's approval brought this total up to 2, enough to finalize approval for the edit and complete the task.
- Our long strange trip is done.
Wow. Uh... This is pretty rare; it might not be worth fixing at all. But if we were gonna fix it, I'd probably lean toward the advice given in this comment above the scheduled task noted in step #8 above:
// TODO: When SuggestedEdits are no longer L2S, we can remove the need for this
// by making the insert of the reviewtask and the insert of the suggested
// edit part of same statement/transcation.
That and... Maybe pass the review task ID into the suggested edit logic somehow so they don't get separated.