Meta Stack Exchange is a question and answer site for meta-discussion of the Stack Exchange family of Q&A websites. It only takes a minute to sign up.
Sign up to join this community
In posts where the most recent edit is a rollback, a rollback button appears (example):
Clicking it shows this error:
Related: I can rollback to the most recent revision, but I think this was introduced after the update of the rollback popup, and I can't reproduce the bug anymore.
This will be fixed in the next build.
There are a few scenarios where rollback will fail. One is rolling back to the current revision. Another is rolling back to a revision that exactly matches the current revision.
As such, when we first introduced rollbacks in 2008, we hid the rollback button if:
N" and we were looking at Revision N.Less than a year later when we refactored the view, we converted that OR to an AND, meaning we showed the button on every revision except the current one, but also on the current one if it was a rollback.
This probably went under the radar for a decade because we were actually suppressing the error message. This is because, as I recently discovered, zero-change edits execute rollbacks and we didn't want to show errors when they hit these conditions.
The reason the errors are visible now, and probably why this came to your attention, is that I fixed a bug that was hiding "Rollback" in the post menu and made changes to resurface the error message when I was confronted with a button that just wouldn't go away no matter how many times I clicked.
git hoops to trace it. The problem was it did Post.Owner == Current.User` which probably broke when we stopped fetching the full owner or a query switched to Dapper. Comparing ids fixed it.
Jan 11, 2021 at 21:41