9

Today I upvoted an answer that was unaccepted, and now in the author's reputation history I can see a -5 event, but it's not red, it's green!

enter image description here

But I thought this was fixed last month?

13
  • No the color bug was never fixed. ("Expect a fix soon" is codename for "we will never fix it, but don't want to hurt you by saying this") Mar 16 at 16:32
  • 2
    @ShadowWizard I highly doubt though that this is the type of thing they'd put off fixing. Dan been willing to fix all the bugs we've pointed out, and it's far more likely that this is an oversight/edge case.
    – user1136431
    Mar 16 at 17:15
  • 1
    Green is correct. They could have been at a deep red -15, now only at -5, worth a green color ...
    – rene
    Mar 16 at 17:46
  • 1
    @richardec Dan has been willing, past tense, when it was still fresh. Check it out yourself. Since Feb 25th, about three weeks ago, not a single comment or edit from him on the bugs reported since. I would be really glad to stand corrected and see him back fixing the bugs, but I have a feeling it just won't happen. Mar 16 at 17:49
  • ;I pinged him...we'll see. I don't even know what kind of notifications he gets from SE...
    – user1136431
    Mar 16 at 17:55
  • 1
    @ShadowWizardSaysNoMoreWar Don't you think they did their best, but missed some details? Mar 16 at 20:01
  • 1
    @Ann seems probable to me. All we can see is that "it's the same bug", but in reality there could be a hundred causes. Like you have the number 42, but you have no idea if it was made by 6*7 or 21+21 or what.
    – user1136431
    Mar 16 at 20:14
  • 2
    I implemented a fix to a similar but distinct bug recently (the one @richardec mentioned me in today). I'll look into this one and try to figure out what’s going on.
    – Dan Cormier Staff
    Mar 16 at 20:18
  • 2
    @ShadowWizardSaysNoMoreWar FWIW, sorry for the delays. That Activity post specifically needs some love but is a bit of a mess and it's been hard for me to triage. I’ve addressed many issues in there still tagged review or planned in the course of development but I’ve neglected to update tags or comments because there’s so much to dig through.
    – Dan Cormier Staff
    Mar 16 at 20:19
  • After a few attempts at reproducing this locally and finding an active example in production (the linked user no longs reflects the issue), I've yet to come across this issue. If anyone knows of an active example (especially a rep change example from a prior date), please mention it. Thanks in advance :)
    – Dan Cormier Staff
    Mar 16 at 20:49
  • @Dan Really! Well, another user upvoted that answer, so probably that's why. So unnaccepting an answer and the upvoting it doesn't work? Perhaps, since I assume you have live DB access, you can query for answers unaccepted today and upvote one?
    – user1136431
    Mar 16 at 20:52
  • 4
    I spoke too quick! I can reproduce it locally and now have a fix for the bug. The nested item for rep changes uses a different partial than the parent elements and that nested partial didn't receive the fix (yet). Expect a fix to ship within the next 24 hours.
    – Dan Cormier Staff
    Mar 16 at 21:10
  • 1
    @DanCormier well that's rare case where I'm glad to be wrong. Thanks. :) Mar 18 at 15:36

1 Answer 1

4

But I thought this was fixed last month?

Yep! Well, the same bug in a different place was fixed. This is a classic case of fixing a bug in one partial when it exists in two. An additional fix has been shipped to production. Sorry for the confusion!

The function that sets the color of the reputation change used conditionals based on the reputation increase/decrease independent of one another instead of considering net reputation change. Basically, if any reputation increase occurred with a given entry, the net reputation change would have the green color applied.

You must log in to answer this question.