8

Related: What happened to FavoriteCount? - my educated guess is that a NULL value indicates a question has never been favorited or bookmarked, and 0 that it was. Since the values are so different from what the column name conveys, shouldn't it just be dropped? That would break some old queries of course, but with developer tools it's often better to throw an exception rather than produce deceptive results.

(Alternative title: ALTER TABLE Posts DROP COLUMN FavoriteCount - but I was afraid that would encourage people to post all kinds of SQL questions here ...)

12
  • Hmm maybe also time to merge bookmarks into saves? The tag wiki for bookmarks is now just wrong, and the tag itself is misleading, making people think bookmarks still exist. Commented Dec 13, 2022 at 17:08
  • 4
    @ShadowTheKidWizard either that, or keep them separate (but point out that bookmarks no longer exist and are replaced by saves). The merge from [favorites] to [bookmarks] was a no-brainer because it was the same functionality - this one I'm not sure about that. Sounds like another question :)
    – Glorfindel Mod
    Commented Dec 13, 2022 at 17:16
  • 2
    Technically it should be dropped from PostsWithDeleted. Posts is only a view over the actual table ...
    – rene
    Commented Dec 13, 2022 at 18:11
  • Don't they even still have emailhash from the dawn of time when that was public?
    – Laurel
    Commented Dec 13, 2022 at 18:18
  • 2
    I totally agree, we'll take care of it
    – Kyle Pollard StaffMod
    Commented Dec 13, 2022 at 18:23
  • 1
    @ShadowWizardChasingStars: Related request (though not quite the same, since I assume your suggestion is more about merging the tags on MSE): Change the default tag [bookmarks] to [saves] on per-site metas
    – V2Blast
    Commented Dec 13, 2022 at 18:26
  • @V2Blast yeah, related, not same. Thanks! :) Commented Dec 13, 2022 at 18:29
  • @Laurel I'm pretty sure all email hashes have been cleared from SEDE long ago. Commented Dec 13, 2022 at 18:29
  • @ShadowWizardChasingStars The column still exists on the Users table, but it's blank in every row.
    – Laurel
    Commented Dec 13, 2022 at 19:22
  • @rene how do you know? :O
    – Braiam
    Commented Dec 13, 2022 at 19:48
  • @Laurel yup, that's why "cleared" and not "removed". ;) Commented Dec 14, 2022 at 8:22
  • @Braiam inspection of the schema: data.stackexchange.com/stackoverflow/query/1688218 or implementation details
    – rene
    Commented Dec 14, 2022 at 18:38

0

You must log in to answer this question.