Regardless the state of a favourite star, the tool tip text is:
"Click again to undo".
When deselected, the tool tip text should read
"Click to mark as a favourite".
This follows Steve Krug's "Don't Make me think" principle.
Meta Stack Exchange is a question and answer site for meta-discussion of the Stack Exchange family of Q&A websites. It only takes a minute to sign up.Sign up to join this community
Talking about this, I guess the part where it tells you
(click again to undo) is fair, as it's just a for your information part. But the part where it says,
This is a favorite question, that should be a typo, since it is not a favorite question.
Nice catch by you, but team should place a try block and remove this! And update it to something like this
Click to mark it as a favorite question (Click again to undo)
Where the part inside the bracket would be taken as a for your information part.
That would be more like it when its not a favorite question and you need to favorite it.