Related: On migrating from SO: how to do this efficiently and appropriately.

I've just come accross a question which I believe is ideal for code review. However it's already got an accepted answer.

I can't flag that it should go on code review, and I'm not sure flagging is the best approach.

Should I ignore or flag the question?

In general (assuming no accepted answers) how should I mark questions as suitable for CR?

The question in question is How can I reduce the Cyclomatic Complexity of this?


To me this is the definition of a proper code review question.

  • Its a beginner who is asking about best practice.
  • It contains functional code.
  • There are several comments already which are off topic for SO about the use of instanceof and proper OO practices.

Code review could give better answers because more of the other information that is being freely offered is on topic there.

Infact the most upvoted answer pretty much is talking about practices. Not the accepted answer.

  • 4
    I don't think it should be migrated if it already has an accepted answer - it still is on topic on SO. But I'm not familiar with the rules regarding this, so I can be wrong. – Pëkka May 4 '11 at 8:54
  • yeah I kinda thought that – Wes May 4 '11 at 8:56
  • 3
    @Pekka: Just because it has an accepted answer doesn't mean that it is on-topic or welcome. I also think that this would fit better on CR, but it's also on-topic on SO, since he's asking a specific programming question. – Time Traveling Bobby May 4 '11 at 9:22
  • Yes it is on topic. :S – Wes May 4 '11 at 10:24
  • 6
    @Bobby - there are two reasons to migrate. One - it's off topic for the current site. Two - even though it's on topic it would get better answers on another site. Neither of these reasons apply in this case. The question is on topic for SO and it already has an acceptable answer. – ChrisF May 4 '11 at 11:41
  • Is everyone in agreement it should stay where it is? I think it may get better answers on another site because those answers would be on topic. This question already has several comments relating to using instanceof and relating to OOP patterns. These comments are much more on topic on code review. – Wes May 4 '11 at 12:56
  • I don't think Code Review would add significantly different answers at this point. I agree with ChrisF. – Adam Lear May 4 '11 at 13:53
  • 1
    @AnnaLear @ChrisF @Wes @Bobby @Pekka are we asking about this type of question or about this question? – jcolebrand May 4 '11 at 17:09
  • @drachenstern I was asking in general but with a specific example – Wes May 4 '11 at 17:31

@Malachi almost said it all. I'll only add this:

From the CodeReview Help Center:

[For a question] to be on-topic the answer must be yes to all questions:

  • Does my question contain code? (Please include the code in the question, not a link to it)
  • Did I write that code?
  • Is it actual code from a project rather than pseudo-code or example code?
  • Do I want the code to be good code, (i.e. not code-golfing, obfuscation, or similar)
  • To the best of my knowledge, does the code work?
  • Do I want feedback about any or all facets of the code?

Code-review SO questions that pass the above test should be migrated. Ignoring them, not migrating them or closing them as off-topic is likely to just frustrate the OP and, when/if they find out about CR, encourages cross-posting.

Migrating good CR candidates, however, can have a highly positive impact on CR traffic (and voting!), as migrated questions still show up in SO's questions list. One of the latest SO questions migrated to CR actually made it to the top of that week's top hits in the CR weekly newsletter. Wasn't a really great question, not even an exciting code review (was a question with trivial code), but it was nice to see votes pile up on a CR question (~125 votes generated with the top 3 answers), and I think a big part of that was all thanks to the visibility granted by migration.


when I want to flag a question for Code Review I just use the

other (needs ♦ moderator attention)

option on the flag option list and then say why I think it should be moved to Code Review. sometimes the Moderator says no.

from what I understand, the reason why it isn't an option to migrate to Code Review is because it is still a Beta Site, so flagging it that way is the only way to get it migrated. (As far as I know)

  • 3
    +1 Yep, pretty much. I also like this method because it allows the mods to decide if the question belongs on CR, rather than letting other (possibly unsure) users decide. There have been situations where something migrated to CR was still off-topic. That just frustrates the OP and the rest of us. – Jamal Oct 28 '13 at 4:16
  • best way I think. but gives the moderators a lot of stuff to do if there are a lot of questions being flagged – Malachi Oct 28 '13 at 4:22
  • 1
    True, but I still think it's better to let the moderators decide, especially if there's uncertainty. Although not entirely related, Winston Ewert says here that we should flag if a question seems good for migration. Granted, this is because we cannot migrate questions anywhere but Meta Code Review, but moderators would still have a better idea about what to do. – Jamal Oct 28 '13 at 4:28

You must log in to answer this question.

Not the answer you're looking for? Browse other questions tagged .