Skip to main content
...
Source Link
m0sa
  • 22.2k
  • 3
  • 83
  • 95

Thanks for pointing this out. It'll be fixed in build rev 2013.7.30.1289 (meta) / 2013.7.30.902 (sites).

As it happens some views got smart over time (thanks to fixing pluralization bugs in the past I guess..) and include own pluralization logic. This particular one had a one liner in a helper somewhere similar to count == 1 ? str.Substring(0, str.Length - 1) : str. Code like this is becoming obsolete as we're moving views to our moonspeaklocalization API, and is easily missed when batch replacing hard coded strings. So the problem was that pluralization was performed twice, once in moonspeakvia the API and then in the view.

I guess we're now paying the price for fixing pluralization in the past and Jeff was right all along!

But anyway, watch out for those, winter is coming...

Thanks for pointing this out. It'll be fixed in build rev 2013.7.30.1289 (meta) / 2013.7.30.902 (sites).

As it happens some views got smart over time (thanks to fixing pluralization bugs in the past I guess..) and include own pluralization logic. This particular one had a one liner in a helper somewhere similar to count == 1 ? str.Substring(0, str.Length - 1) : str. Code like this is becoming obsolete as we're moving views to moonspeak, and is easily missed when batch replacing hard coded strings. So the problem was that pluralization was performed twice, once in moonspeak and then in the view.

I guess we're now paying the price for fixing pluralization in the past and Jeff was right all along!

But anyway, watch out for those, winter is coming...

Thanks for pointing this out. It'll be fixed in build rev 2013.7.30.1289 (meta) / 2013.7.30.902 (sites).

As it happens some views got smart over time (thanks to fixing pluralization bugs in the past I guess..) and include own pluralization logic. This particular one had a one liner in a helper somewhere similar to count == 1 ? str.Substring(0, str.Length - 1) : str. Code like this is becoming obsolete as we're moving views to our localization API, and is easily missed when batch replacing hard coded strings. So the problem was that pluralization was performed twice, once via the API and then in the view.

I guess we're now paying the price for fixing pluralization in the past and Jeff was right all along!

But anyway, watch out for those, winter is coming...

added explanation
Source Link
m0sa
  • 22.2k
  • 3
  • 83
  • 95

Thanks for pointing this out. It'll be fixed in build rev 2013.7.30.1289 (meta) / 2013.7.30.902 (sites).

As it happens some views got smart over time (thanks to fixing pluralization bugs in the past I guess..) and include own pluralization logic. This particular one had a one liner in a helper somewhere similar to count == 1 ? str.Substring(0, str.Length - 1) : str. Code like this is becoming obsolete as we're moving views to moonspeak, and is easily missed when batch replacing hard coded strings. So the problem was that pluralization was performed twice, once in moonspeak and then in the view.

I guess we're now paying the price for fixing pluralization in the past and Jeff was right all along!

But anyway, watch out for those, winter is coming...

Thanks for pointing this out. It'll be fixed in build rev 2013.7.30.1289 (meta) / 2013.7.30.902 (sites).

Thanks for pointing this out. It'll be fixed in build rev 2013.7.30.1289 (meta) / 2013.7.30.902 (sites).

As it happens some views got smart over time (thanks to fixing pluralization bugs in the past I guess..) and include own pluralization logic. This particular one had a one liner in a helper somewhere similar to count == 1 ? str.Substring(0, str.Length - 1) : str. Code like this is becoming obsolete as we're moving views to moonspeak, and is easily missed when batch replacing hard coded strings. So the problem was that pluralization was performed twice, once in moonspeak and then in the view.

I guess we're now paying the price for fixing pluralization in the past and Jeff was right all along!

But anyway, watch out for those, winter is coming...

Source Link
m0sa
  • 22.2k
  • 3
  • 83
  • 95

Thanks for pointing this out. It'll be fixed in build rev 2013.7.30.1289 (meta) / 2013.7.30.902 (sites).