51

On Stack Overflow, suggested edits need two reviewers. So when you're the first reviewer to give your opinion (approve or reject) or if you're the second but vote the other way than the first reviewer, the edit stays in the queue. This has two annoying consequences when you're going through the suggested edit list (5k only):

  • If you cast the deciding vote, the entry for this edit disappears from the list (it's moved to a header line at the top of the list). Otherwise the edit remains in place. This is annoying because it means the position of the next entry on the screen depends on something that shouldn't be relevant (whether you just cast the deciding vote). It's especially annoying because the entry can take a couple of seconds to disappear when it does, which has led me to click on the wrong row a couple of times, when the next edit was an obvious accept or reject.
  • If you revisit the list and one of the edits you voted on still hasn't been decided, the entry appears again (with no buttons). Why show me the entry again? There's nothing I can do about it any more.

Here's the behavior I'd like:

  • An edit never disappears from the list as long as I don't reload the page.
  • If I reload the page, edits I've already voted on don't appear.

Alternatively:

  • When I've voted on an edit, it disappears to the collapsed list at the beginning, and stays there even if I reload the page.
  • The disappearance should be instantaneous, with no fading.

Either way, please make the behavior on voting consistent whether my vote was the deciding one or not. And if the page is changed when I click on a vote button, the change should be instantaneous.

But please don't let that deter you from reviewing a few suggested edits on Stack Overflow. Visit the list and review one page (30 suggestions). We get 500–800 suggestions on a typical day. If 2% of the eligible ~5000 people do one page every day and vote on half the suggestions they see, we're good.

5
  • 6
    Another annoyance: more than enough times I've been working off the list, gone off to one of the actual questions to see the edit in full context, spent a couple minutes there, and then come back to the list and start Approving/Rejecting edits that have already been taken care of by a couple different reviewers. This can be remedied by refreshing the page, but I forget to do that a lot. It also means I have to work back down through the refreshed list and ignore the ones I've already looked at and skipped.
    – Rob Hruska
    Commented Feb 8, 2012 at 14:56
  • 5
    In a way, you don't even need to see whether you'll be casting a deciding vote. If someone voted already, why do you need to know? If anything, seeing what someone else votes will only make your decision less objective because you might be partially swayed to go along with their vote and not put in as much effort as you would if someone hadn't already voted. So the system could be: You see a list of edits, you vote approve/decline and they stay in place. When you reload the page, anything you've voted on doesn't show up anymore. No reason to show other votes or do the fancy fade-out.
    – Ben Lee
    Commented Feb 14, 2012 at 2:48
  • 1
    I would +1 this... but it seems I did when it was first posted last year.. shame nothings been done about this.
    – Matt
    Commented May 18, 2012 at 9:07
  • 1
    AND make the "Improve" button from the queue open a new tab! Reviewing edits is already enough of a chore. Why do I have to fight the UI the whole time too?
    – jscs
    Commented Jul 9, 2012 at 20:36
  • This is pretty much all taken care of with the queue-based interface, albeit not in quite the way suggested.
    – Shog9 Mod
    Commented Jan 19, 2013 at 0:54

2 Answers 2

16
+800

I was in the middle of writing my own question ranting about this. The three solutions I would accept were as follows;

  1. Never remove a post from the list, as you loose your place in the queue. Instead, fade the post out so the user knows they've handled it. Regardless of whether it's the deciding vote or not.

    enter image description here

  2. If the post is removed, scroll the user to a consistent place on the place; i.e. the next post that is to be removed.

  3. Have House of Pain - Jump Around playing constantly in the background whilst in the suggested-edit queue.

    enter image description here

EDIT: In the meantime, I've written a Userscript which fixes these annoyances.

22
  • 3
    +1 for option #1. +100 for option #3.
    – user7116
    Commented Feb 16, 2012 at 14:23
  • +1 You actually wrote the Chrome extension? Wish you could write one for FF :) Commented Jun 9, 2012 at 13:39
  • @SiddharthRout I looked at the option of porting it; it uses jQuery using jQuery inside a FF extension is a major headache.
    – vcsjones
    Commented Jun 9, 2012 at 14:06
  • 1
    @vcsjones: I am sure it is. And hence a bounty ;) Also the bounty is not for fading it but to remove it completely from my view on page refresh. Commented Jun 9, 2012 at 14:07
  • I cannot stop laughing at option #3.
    – Mr.Wizard
    Commented Jun 9, 2012 at 14:07
  • Like Siddharth Rout, I'd prefer it if the items I've acted on were moved to the top, but the important thing is that the behavior is consistent. That, and not having edits I've already seen appear again when I reload the page. Thank you! (I'm not giving this an the check mark, I reserve it for the day — should it ever come — when this is a standard feature.) Commented Jun 12, 2012 at 18:40
  • @SiddharthRout: Give the updated link (which is now an userscript) a go. Let me know if you come across any problems (I know edits fade at the moment... working on a removal option).
    – Matt
    Commented Jun 13, 2012 at 10:25
  • @Matt: Perfect. will wait for the "Removal" option. Commented Jun 13, 2012 at 10:26
  • @SiddharthRout: The new version adds a settings box to the bottom of the suggested edit queue. Change the "When an action is taken on an edit..." option to "Add to the top" and let me know how it goes! (if you can't see the settings box, try clearing your cache).
    – Matt
    Commented Jun 13, 2012 at 13:15
  • @Matt Thanks, I just tried the fade option. It fades even if I get the “out of votes” message. I would like to fade only if my vote was taken into account, not if I ran out of votes and also not if the edit was already rejected by the time I approved or vice versa. Commented Jun 13, 2012 at 13:22
  • @Gilles: I've just pushed a version which won't fade out on "out of votes"; give it 10 minutes for the Github CDN to clear and you should get it automatically. The same fix might also have caught the case of the edit being approved/ rejected before you got to it, but I need to see an example of the server response in that case to know what to check for... :(
    – Matt
    Commented Jun 13, 2012 at 13:33
  • @Matt “Out of votes” stays in place now, thanks. I can't test anything else until tomorrow. Commented Jun 13, 2012 at 14:06
  • @Gilles: Was thinking of something like this for a better UI for titles... was this what you had in mind?
    – Matt
    Commented Jun 13, 2012 at 14:16
  • @Matt Yes, that would be great. Or perhaps left and right as had been suggested before. Commented Jun 13, 2012 at 14:20
  • @Matt “This edit was already approved” stays in place. Yay! If you need a transcript for testing: pastebin.com/43uekwAD Commented Jun 14, 2012 at 2:39
5

This is less of an answer and more of an additional gripe.

When choosing to 'Improve' a suggested edit, you're taken to the stand-alone edit page and on saving your edit, returned to the question page (not back to the Edit queue).

Can we not just edit in-place à la the other Review queues (Late Answers, etc.)?

EDIT: Now posted as a question

2
  • Widor, I think this justifies being it's own separately posted question. If this hasn't already been asked, consider asking it as a question... I have to keep reminding myself to use right-click -> open in new tab so that I don't lose my place on the edits page. It's very annoying indeed.
    – jmort253
    Commented Jun 20, 2012 at 4:10
  • 1
    @jmort253 I'll have a search and do so if I can't find one then. Meanwhile, save yourself one second per edit by middle-clicking the link rather than selecting from the context menu!
    – Widor
    Commented Jun 20, 2012 at 9:35

Not the answer you're looking for? Browse other questions tagged .